mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 56680: Apply glog to agent exit messages.
Date Tue, 14 Feb 2017 21:05:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56680/
-----------------------------------------------------------

Review request for mesos and haosdent huang.


Bugs: MESOS-7115
    https://issues.apache.org/jira/browse/MESOS-7115


Repository: mesos


Description
-------

EXIT(...) doesn't format messages like glog so it's less easy to
tell where a message came from and when it was emitted. For agent all
initialization messages, perform a LOG(ERROR) followe by an exit. For
other agent exit scenarios, use LOG(FATAL) or the equivalent CHECK().


Diffs
-----

  src/slave/slave.cpp ebba8e16bc9ec45781183e78cb5a3c351a5f65f5 

Diff: https://reviews.apache.org/r/56680/diff/


Testing
-------

make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message