mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 56587: Fixed a crash on the master upon receiving an invalid inverse offer.
Date Mon, 13 Feb 2017 07:30:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56587/#review165296
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56587]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 13, 2017, 5:44 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56587/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 5:44 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7119
>     https://issues.apache.org/jira/browse/MESOS-7119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The erroneous invariant check for `slaveId` can be trigerred when
> the master accepts an invalid inverse offer or when the inverse offer
> has been already rescinded.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp dff320acd1a13995d51cc0c303edea0cdfaa336d 
>   src/tests/master_maintenance_tests.cpp 9861d1186e046a4fd547e73825c02b71eedd5ce2 
> 
> Diff: https://reviews.apache.org/r/56587/diff/
> 
> 
> Testing
> -------
> 
> make check + added a test that used to crash before.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message