mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gy...@apache.org>
Subject Re: Review Request 56370: Added a test to ensure multi-role framework receiving offers.
Date Sat, 11 Feb 2017 02:35:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/#review165229
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/tests/master_tests.cpp (line 6379)
<https://reviews.apache.org/r/56370/#comment237057>

    s/->/.get().



src/tests/master_tests.cpp (line 6382)
<https://reviews.apache.org/r/56370/#comment237058>

    ditto


- Guangya Liu


On 二月 9, 2017, 2:28 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56370/
> -----------------------------------------------------------
> 
> (Updated 二月 9, 2017, 2:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-7062
>     https://issues.apache.org/jira/browse/MESOS-7062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that multi-role framework should receive offers for
> each of its roles.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 
> 
> Diff: https://reviews.apache.org/r/56370/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message