mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56569: Updated `drop` log message from `ERROR` to `WARNING`.
Date Sat, 11 Feb 2017 01:19:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56569/#review165226
-----------------------------------------------------------


Ship it!




I didn't do an audit but you should probably look to see if our existing message ignoring
logging (not all of them use drop) use WARNING.

- Benjamin Mahler


On Feb. 11, 2017, 1:07 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56569/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2017, 1:07 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `drop` log message from `ERROR` to `WARNING`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 80d481b2ea1435147cd213383008435f35112d92 
> 
> Diff: https://reviews.apache.org/r/56569/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message