-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56378/#review165214
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/hierarchical_allocator_tests.cpp (line 3690)
<https://reviews.apache.org/r/56378/#comment237037>
Hm.. why did you need this?
src/tests/hierarchical_allocator_tests.cpp (line 3703)
<https://reviews.apache.org/r/56378/#comment237039>
Did you mean to do 1000.0 or 1000? How about using something like `Days(1).secs()`?
src/tests/hierarchical_allocator_tests.cpp (lines 3723 - 3724)
<https://reviews.apache.org/r/56378/#comment237038>
How about putting this above the revive call? E.g.
```
// Revive offers for role1, after which the agent's resources
// should be offered to it.
allocator->reviveOffers(framework.id(), "role1");
expected = Allocation(
framework.id(),
{{"role1", {{agent.id(), agent.resources()}}}});
AWAIT_EXPECT_EQ(expected, allocation);
```
- Benjamin Mahler
On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56378/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:10 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jay Guo.
>
>
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test case for suppress and revive with multi role framework.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec
>
> Diff: https://reviews.apache.org/r/56378/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> ```
> ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole"
--gtest_repeat=100
> ```
>
>
> Thanks,
>
> Guangya Liu
>
>
|