mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56537: Added a test to ensure framework can upgrade to support MULTI_ROLE.
Date Sat, 11 Feb 2017 00:17:34 GMT


> On Feb. 10, 2017, 9:33 a.m., Jay Guo wrote:
> > src/tests/master_tests.cpp, lines 6409-6411
> > <https://reviews.apache.org/r/56537/diff/1/?file=1629346#file1629346line6409>
> >
> >     How to check the task is still running here?

If no status update is received we know it's still running. To check it more explicitly we
can perform reconciliation.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56537/#review165087
-----------------------------------------------------------


On Feb. 10, 2017, 9:32 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56537/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2017, 9:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael
Park.
> 
> 
> Bugs: MESOS-7035
>     https://issues.apache.org/jira/browse/MESOS-7035
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A framework can be upgraded to be MULTI_ROLE capable even with task
> running, as long as it does not change role while upgrading.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 
> 
> Diff: https://reviews.apache.org/r/56537/diff/
> 
> 
> Testing
> -------
> 
> WIP
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message