mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gy...@apache.org>
Subject Re: Review Request 56376: Updated allocator test to support create multi role framework.
Date Thu, 09 Feb 2017 07:47:20 GMT


> On 二月 8, 2017, 6:48 a.m., Jay Guo wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 203-205
> > <https://reviews.apache.org/r/56376/diff/1/?file=1626287#file1626287line203>
> >
> >     IMO, since this is for testing purpose, we probably don't need to rigidly require
test writers to construct frameworkInfo with `MULTI_ROLE` capability. If `createFrameworkInfo`
is called with multiple roles, we could simply add `MULTI_ROLE` implicitly. And one could
still explicitly add `MULTI_ROLE` to capabilities with a single role. Then we don't need to
change existing test cases and avoid future confusion. What do you think?

Yes, but the only problem is that we cannot specfify multiple roles with the first paramter
here `const string& role`, so I have to update it to `const set<string>& roles`.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56376/#review164638
-----------------------------------------------------------


On 二月 7, 2017, 10:10 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56376/
> -----------------------------------------------------------
> 
> (Updated 二月 7, 2017, 10:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
>     https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated allocator test to support create multi role framework.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec

> 
> Diff: https://reviews.apache.org/r/56376/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message