mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54639: Implemented the 'create()' method of OCI store.
Date Wed, 08 Feb 2017 23:36:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54639/#review164794
-----------------------------------------------------------




src/Makefile.am (line 951)
<https://reviews.apache.org/r/54639/#comment236571>

    Let's align the tailing backslash.



src/Makefile.am (line 1092)
<https://reviews.apache.org/r/54639/#comment236572>

    Ditto.



src/slave/containerizer/mesos/provisioner/oci/paths.hpp (lines 36 - 39)
<https://reviews.apache.org/r/54639/#comment236601>

    Can you elaborate a bit more the layout here?
    
    so `layer_id` is the digest? What is `config.json`? Does it store decompressed content,
or the original content? what about image configs?
    
    Given this https://github.com/opencontainers/image-spec/blob/master/image-layout.md, my
hunch is that we should probably cache the original blob, as well as decompressed content,
potentially in separate subdirectories.
    
    ```
    <oci_store_dir>
       |--- blobs/  # this is origional CAS blobs.
               |--- sha256/
                       |--- <digest>
                       |--- <digest>
                       |--- ...
       |--- layers/ # this is decompressed filesystem change sets
               |--- <id? digest?>
               |--- ...
    ```
    
    Looks like we probably do not need `configs` or `manifests` directory for now because
the only media type is json, and can be directly read from `blobs/`.
    
    Another thing to consider is the conversion to overlayfs opaque file from whiteout files
as you did before. So for `layers` directory, we probably need to have a `backend` in the
path (e.g., `layers/overlayfs/...`).



src/slave/containerizer/mesos/provisioner/oci/store.cpp (lines 62 - 68)
<https://reviews.apache.org/r/54639/#comment236597>

    Joseph has a URI parser chain that parse any URI. We should try to support any uri that
fetcher supports.
    https://reviews.apache.org/r/46580/
    https://reviews.apache.org/r/46588/
    
    We should try to land that and use the URI parser here to parse the uri into `URI` struct,
and call `fetcher->fetch(URI uri)`


- Jie Yu


On Feb. 1, 2017, 1:17 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54639/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 1:17 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the 'create()' method of OCI store.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54639/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message