mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56330: Enabled suppress offer per role.
Date Wed, 08 Feb 2017 21:47:46 GMT


> On Feb. 6, 2017, 9:15 p.m., Benjamin Mahler wrote:
> > include/mesos/allocator/allocator.hpp, lines 352-353
> > <https://reviews.apache.org/r/56330/diff/1/?file=1624787#file1624787line352>
> >
> >     Hm.. it doesn't look like any of the comments in this header make use of @param.
> 
> Guangya Liu wrote:
>     Do you mean we do not need `@param`? But there are actually many places using such
format as https://github.com/apache/mesos/blob/master/include/mesos/allocator/allocator.hpp#L76-L86
, comments?

Ah I see now, sounds good I will drop this.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56330/#review164407
-----------------------------------------------------------


On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56330/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 10:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
>     https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled suppress offer per role.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 71a40537b673e44ecdd5327d9a9f083faa7fc13a 
>   src/master/allocator/mesos/allocator.hpp e3c86181677302dbfc3b213715196122f96e312c 
>   src/master/allocator/mesos/hierarchical.hpp 896abcdf0727f986eef3a1a9304a0e4847094057

>   src/master/allocator/mesos/hierarchical.cpp 56d6791baa64189523df668749f4a7ab67d6b363

>   src/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a 
>   src/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961 
>   src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec

> 
> Diff: https://reviews.apache.org/r/56330/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> Will add a test case to enable suppress per role in follow up patches.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message