mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56371: Enabled `ReviveOffersMessage` support revive per role.
Date Wed, 08 Feb 2017 21:20:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56371/#review164771
-----------------------------------------------------------


Ship it!




I'm fine adding this here, but it seems weird that we wold update the protobuf but not update
the scheduler driver. Are we assuming that other bindings might benefit from this? Are we
still updating the old API?


src/messages/messages.proto (lines 269 - 271)
<https://reviews.apache.org/r/56371/#comment236530>

    How about:
    
    Removes filters for the specified role. If a role is not provided, then this this is equivalent
to passing all of the framework's subscribed roles.
    
    Do you want to note that this hasn't been added to the v0 API?


- Benjamin Mahler


On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56371/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 10:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
>     https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled `ReviveOffersMessage` support revive per role.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ceb9bf7e4be7e0e43a166d7706bd0ab4fd9ed578 
>   src/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a 
>   src/messages/messages.proto 7a2f37b78a8edcd372558f77f15e6b249742e321 
> 
> Diff: https://reviews.apache.org/r/56371/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message