mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test.
Date Tue, 07 Feb 2017 21:28:23 GMT


> On Feb. 7, 2017, 6:57 p.m., Gilbert Song wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, lines 241-242
> > <https://reviews.apache.org/r/56284/diff/3/?file=1625443#file1625443line241>
> >
> >     Maybe you should fix the comment.

Yes, the comment should be changed.


> On Feb. 7, 2017, 6:57 p.m., Gilbert Song wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, lines 268-271
> > <https://reviews.apache.org/r/56284/diff/3/?file=1625443#file1625443line268>
> >
> >     Since you set `cached` as false and manually remove one layer from the store.
This test only verifies that a missing layer will be pulled if `cached` is set as false.
> >     
> >     I do not see how it verifies the local puller will skip pullin the existing
layers.

I agree that this test does not explicitly verify that `LocalPuller` skips the layer. My first
intention was to write 2 separate tests: for `LocalPuller` and for `Store`. But such tests
assumed a lot of details about staging directory layout. So Jie suggested this test that is
simpler and less fragile and exercises the skipping layers code.


- Ilya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56284/#review164539
-----------------------------------------------------------


On Feb. 6, 2017, 8:40 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56284/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-7045
>     https://issues.apache.org/jira/browse/MESOS-7045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new test verifies that that local Docker puller and store will skip layers that are
already pulled.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 99e0820fa47303896f70c81cfb91cd34f0474e55

> 
> Diff: https://reviews.apache.org/r/56284/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message