mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 56327: Updated Suppress and Revive proto to support per role.
Date Mon, 06 Feb 2017 21:03:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56327/#review164405
-----------------------------------------------------------


Ship it!





include/mesos/scheduler/scheduler.proto (line 286)
<https://reviews.apache.org/r/56327/#comment236099>

    s/offer/offers/
    s/spcified/specified/
    
    Also could you mention the case where role is unset and that revives offers for all of
the roles the framework is subscribed to?



include/mesos/scheduler/scheduler.proto (line 373)
<https://reviews.apache.org/r/56327/#comment236100>

    Ditto here.



include/mesos/v1/scheduler/scheduler.proto (line 276)
<https://reviews.apache.org/r/56327/#comment236101>

    Ditto here.



include/mesos/v1/scheduler/scheduler.proto (line 363)
<https://reviews.apache.org/r/56327/#comment236102>

    Ditto here.


- Benjamin Mahler


On Feb. 6, 2017, 3:13 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56327/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 3:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jay Guo.
> 
> 
> Bugs: MESOS-6638
>     https://issues.apache.org/jira/browse/MESOS-6638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated Suppress and Revive proto to support per role.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 5f4635d523286754a61aa99e18e79d6c1db9463f 
>   include/mesos/v1/scheduler/scheduler.proto 096c76dfffe03c0e2d6abe84d438c396cc1b0be9

> 
> Diff: https://reviews.apache.org/r/56327/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message