mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.
Date Mon, 06 Feb 2017 04:07:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54821/#review164301
-----------------------------------------------------------


Fix it, then Ship it!




Thanks a lot for @zhitao's great refactor and @jieyu's review. Let me commit it after 1.2.0
release.
I would try to see if it could backport to other active branches at that time as well.


src/docker/docker.hpp (lines 165 - 166)
<https://reviews.apache.org/r/54821/#comment235991>

    ```
        // Environment variable overrides. These overrides will be passed
        // to docker container through "--env-file" option.
    ```



src/docker/docker.cpp (line 713)
<https://reviews.apache.org/r/54821/#comment235989>

    Got error when apply the patch:
    
    ```
    Checking 8 C++ files
    src/docker/docker.cpp:713:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
    Total errors found: 1
    ```



src/docker/executor.cpp (line 477)
<https://reviews.apache.org/r/54821/#comment235994>

    nits:
    
    ```
      void _stop()
      {
    ```


- haosdent huang


On Feb. 5, 2017, 11:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54821/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2017, 11:09 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6808
>     https://issues.apache.org/jira/browse/MESOS-6808
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch creates a wrapper struct for all recognizable docker cli
> options, and separate logic of creating these options to a different
> common function.
> 
> This also enables us to overcome gmock's 10 argument limit.
> 
> No logic change happens in this refactoring patch.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd 
>   src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691 
>   src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d 
>   src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4

>   src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd 
>   src/tests/mock_docker.hpp 829a760d54ad8c7b88256ae5df4c88c9fb18df71 
>   src/tests/mock_docker.cpp 02b6065a01e7e52b0edb38676dfb1bb475584502 
> 
> Diff: https://reviews.apache.org/r/54821/diff/
> 
> 
> Testing
> -------
> 
> `make check` with ROOT and DOCKER filter.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message