mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 56247: Switched to implicit roles in master quota tests.
Date Sun, 05 Feb 2017 21:35:32 GMT


> On Feb. 4, 2017, 12:09 a.m., Michael Park wrote:
> > src/tests/master_quota_tests.cpp, lines 165-182
> > <https://reviews.apache.org/r/56247/diff/1/?file=1622607#file1622607line165>
> >
> >     I don't understand what's happening here... we end up using the same flags,
right? Why didn't we need to specify force flag before?

We don't need to specify the force flag, but I think it makes the intent of the test more
clear. If `force` is not specified but there was a bug in the handling of the role whitelist,
the quota request would still fail (but perhaps with a different status code). Enabling `force`
means that the request should succeed if not for the role-related behavior we're testing.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56247/#review164201
-----------------------------------------------------------


On Feb. 2, 2017, 10:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56247/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 10:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using an explicit role list is deprecated; this change will also make it
> easier to write test cases for hierarchical roles.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp b25f5911579c435549b9bc65994627414357dcb6 
> 
> Diff: https://reviews.apache.org/r/56247/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message