mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 55139: Implemented parse methods for OCI image spec.
Date Sun, 05 Feb 2017 04:02:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55139/#review164262
-----------------------------------------------------------


Fix it, then Ship it!





src/oci/spec.cpp (line 33)
<https://reviews.apache.org/r/55139/#comment235915>

    `const string&`



src/oci/spec.cpp (line 76)
<https://reviews.apache.org/r/55139/#comment235921>

    insert extra blank line above.



src/oci/spec.cpp (line 156)
<https://reviews.apache.org/r/55139/#comment235918>

    Any reason you need this temp var?



src/oci/spec.cpp (lines 163 - 166)
<https://reviews.apache.org/r/55139/#comment235924>

    what if `digest.isNone()`?



src/oci/spec.cpp (lines 182 - 185)
<https://reviews.apache.org/r/55139/#comment235923>

    What if `platform.isNone()`?



src/oci/spec.cpp (line 226)
<https://reviews.apache.org/r/55139/#comment235925>

    replace .get() with `->`



src/oci/spec.cpp (line 271)
<https://reviews.apache.org/r/55139/#comment235920>

    You can use `!annotations->is<JSON::Null>()`



src/oci/spec.cpp (line 319)
<https://reviews.apache.org/r/55139/#comment235926>

    kill this line



src/oci/spec.cpp (line 325)
<https://reviews.apache.org/r/55139/#comment235927>

    no need for this temp var?



src/oci/spec.cpp (line 338)
<https://reviews.apache.org/r/55139/#comment235928>

    Ditto. No need for this temp var.



src/oci/spec.cpp (line 351)
<https://reviews.apache.org/r/55139/#comment235929>

    No need for this temp var?


- Jie Yu


On Feb. 1, 2017, 1:13 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55139/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 1:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented parse methods for OCI image spec.
> 
> 
> Diffs
> -----
> 
>   include/mesos/oci/spec.hpp PRE-CREATION 
>   src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/oci/spec.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message