mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.
Date Sat, 04 Feb 2017 18:38:12 GMT


> On Feb. 4, 2017, 3:23 a.m., Timothy Chen wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 396
> > <https://reviews.apache.org/r/56284/diff/1/?file=1623554#file1623554line396>
> >
> >     How about making this a bit simpler:
> >     "This test verifies that the store skips layers that are already pulled"

Fixed.


- Ilya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56284/#review164235
-----------------------------------------------------------


On Feb. 4, 2017, 6:37 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56284/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2017, 6:37 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-7045
>     https://issues.apache.org/jira/browse/MESOS-7045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test that verifies that Docker `Store` skips layers that are already pulled.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp af9987f88205d00d091f35fa734d5667506aaffd

> 
> Diff: https://reviews.apache.org/r/56284/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message