mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56269: Introduced a `Container` struct on the default executor.
Date Fri, 03 Feb 2017 23:02:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56269/#review164181
-----------------------------------------------------------




src/launcher/default_executor.cpp (line 89)
<https://reviews.apache.org/r/56269/#comment235804>

    hmm. it's unfortunate that each task/container stores TaskInfos of all tasks in the task
group.
    
    can we have a helper function instead that returns a list of container IDs that belong
to the same task group as a given container?
    
    ```
    hashset<ContainerID> taskGroupContainers(const ContainerID& containerId) {}
    ```
    
    or store a shared pointer to TaskGroup?



src/launcher/default_executor.cpp (line 824)
<https://reviews.apache.org/r/56269/#comment235808>

    looks like we are better off keying `containers` on `TaskID` rather than `ContainerID`?



src/launcher/default_executor.cpp (lines 1033 - 1046)
<https://reviews.apache.org/r/56269/#comment235806>

    Can we consolidate killed/killing  into the `Container` struct as well? I think it will
be easy to reason about.


- Vinod Kone


On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56269/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 4:45 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6296
>     https://issues.apache.org/jira/browse/MESOS-6296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This helps us in consolidating various metadata associatd with
> an active child container. Also, this would be used in the future
> for figuring out the task group corresponding to a child container
> and then killing the other child containers belonging to the task
> group when one of the tasks fail; or if a task in the task group
> is explicitly killed by the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 
> 
> Diff: https://reviews.apache.org/r/56269/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message