mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 56174: Added skipping already stored layers to local Docker puller.
Date Fri, 03 Feb 2017 18:07:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56174/
-----------------------------------------------------------

(Updated Feb. 3, 2017, 6:07 p.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-7045
    https://issues.apache.org/jira/browse/MESOS-7045


Repository: mesos


Description
-------

If a layer is already in the store, there's no need to extract it. `RegistryPuller` already
does this and `Store` is ready for such puller behaviour.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp ee391af898886bff9e5b911697f725c5ea53ebd8

  src/tests/containerizer/provisioner_docker_tests.cpp af9987f88205d00d091f35fa734d5667506aaffd


Diff: https://reviews.apache.org/r/56174/diff/


Testing (updated)
-------

Added a test verifying that local puller will skip layes that are already in the store. Ran
`make check`.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message