mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 56250: Cleaned up headers in DRF sorter.
Date Fri, 03 Feb 2017 12:03:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56250/#review164114
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/sorter/drf/sorter.cpp (line 32)
<https://reviews.apache.org/r/56250/#comment235694>

    According to recent discussions and to our code style guide, this should be the first
include in the file.


- Gastón Kleiman


On Feb. 2, 2017, 10:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56250/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 10:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up headers in DRF sorter.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7

> 
> Diff: https://reviews.apache.org/r/56250/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message