mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 56087: Simplified AppC provisioner cache keys hashing.
Date Wed, 01 Feb 2017 18:49:49 GMT


> On Feb. 1, 2017, 6:45 p.m., Gilbert Song wrote:
> > LGTM!
> > 
> > Thanks for the patches, Ilya! Could you add `MESOS-7046` to `BUG` in your patches?
> > 
> > And just let you know that you can post your patches as a chain using `support/post-reviews.py`.

Done. Thanks!


- Ilya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56087/#review163852
-----------------------------------------------------------


On Feb. 1, 2017, 6:49 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56087/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 6:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-7046
>     https://issues.apache.org/jira/browse/MESOS-7046
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Repalced manual `std::map` contents hashing with specialized `boost::hash_combine()`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2

> 
> Diff: https://reviews.apache.org/r/56087/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message