mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55876: Avoided shadowing in `Slave::run()`.
Date Wed, 01 Feb 2017 18:14:05 GMT


> On Jan. 27, 2017, 5:17 p.m., Neil Conway wrote:
> > src/slave/slave.cpp, line 1580
> > <https://reviews.apache.org/r/55876/diff/3/?file=1617529#file1617529line1580>
> >
> >     If we're going to change this, there are a few other places that should also
be changed: e.g., lines 1179, 1226, 1580, potentially 5292.

Good point. I'm inclined to do it in a separate patch then.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55876/#review163288
-----------------------------------------------------------


On Jan. 27, 2017, 11:52 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55876/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 11:52 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 
> 
> Diff: https://reviews.apache.org/r/55876/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message