mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55321: Introduced process::after.
Date Wed, 01 Feb 2017 16:38:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55321/#review163825
-----------------------------------------------------------




3rdparty/libprocess/include/process/after.hpp (lines 50 - 55)
<https://reviews.apache.org/r/55321/#comment235317>

    I was trying to wrap my head around whether this created a bad circular reference `promise
-> future -> discardCallback -> promise` and ultimately a leak of `Future::data`
or not. Are we sure this does not leak when a user e.g., calls it like this?,
    
        after(Seconds(10)); // return value ignored.
    
    I believe adding a clarifyinh comment, or even better a test would be great.


- Benjamin Bannier


On Jan. 8, 2017, 8:49 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55321/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 8:49 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced process::after.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 5e7fdd06ccbed50f248c81e9df1651a3702e7add 
>   3rdparty/libprocess/include/Makefile.am 1d17edd933562849b35740f3935685c8eb154440 
>   3rdparty/libprocess/include/process/after.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/after_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55321/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message