From reviews-return-54528-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 26 01:11:02 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DDB419EBB for ; Thu, 26 Jan 2017 01:11:02 +0000 (UTC) Received: (qmail 11756 invoked by uid 500); 26 Jan 2017 01:11:02 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 11727 invoked by uid 500); 26 Jan 2017 01:11:02 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 11711 invoked by uid 99); 26 Jan 2017 01:11:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 01:11:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C68AA3179D6; Thu, 26 Jan 2017 01:11:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5031041085466499722==" MIME-Version: 1.0 Subject: Re: Review Request 55941: Modified existing tests to support new headers for request streaming. From: Vinod Kone To: Vinod Kone Cc: Anand Mazumdar , mesos Date: Thu, 26 Jan 2017 01:11:00 -0000 Message-ID: <20170126011100.13409.62249@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55941/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20170125194901.13409.5087@reviews.apache.org> In-Reply-To: <20170125194901.13409.5087@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============5031041085466499722== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55941/#review163065 ----------------------------------------------------------- Fix it, then Ship it! src/tests/api_tests.cpp (line 4572) headers src/tests/api_tests.cpp (line 4757) you wanted to test the backwards compatibility here? i.e., setting accept to "application/json" and not "application/recordio". - Vinod Kone On Jan. 25, 2017, 7:49 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55941/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 7:49 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6936 > https://issues.apache.org/jira/browse/MESOS-6936 > > > Repository: mesos > > > Description > ------- > > These tests now set the "Message-Accept", "Message-Content-Type" > headers correctly for streaming responses/requests. > > > Diffs > ----- > > src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d > src/tests/containerizer/io_switchboard_tests.cpp 2e3cfe5003defdb5c46e770b54199d36be03c804 > > Diff: https://reviews.apache.org/r/55941/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > > --===============5031041085466499722==--