From reviews-return-53742-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 13 21:48:09 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35986194B4 for ; Fri, 13 Jan 2017 21:48:09 +0000 (UTC) Received: (qmail 54731 invoked by uid 500); 13 Jan 2017 21:48:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 54700 invoked by uid 500); 13 Jan 2017 21:48:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 54678 invoked by uid 99); 13 Jan 2017 21:48:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2017 21:48:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 614392F98E8; Fri, 13 Jan 2017 21:48:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3315108834809989688==" MIME-Version: 1.0 Subject: Re: Review Request 55509: Validate the StatusUpdate UUID in Master::statusUpdate. From: Mesos ReviewBot To: Jiang Yan Xu Cc: Mesos ReviewBot , James Peach , mesos Date: Fri, 13 Jan 2017 21:48:08 -0000 Message-ID: <20170113214808.1677.23242@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55509/ X-Sender: Mesos ReviewBot References: <20170113184157.1677.12726@reviews.apache.org> In-Reply-To: <20170113184157.1677.12726@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============3315108834809989688== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55509/#review161596 ----------------------------------------------------------- Patch looks great! Reviews applied: [55509] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Jan. 13, 2017, 6:41 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55509/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 6:41 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6920 > https://issues.apache.org/jira/browse/MESOS-6920 > > > Repository: mesos > > > Description > ------- > > To be consistent with Master::statusUpdateAcknowledgement(), validate > that the UUID in the StatusUpdate message is acceptable to the > UUID::fromBytes() parser. > > > Diffs > ----- > > src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040 > > Diff: https://reviews.apache.org/r/55509/diff/ > > > Testing > ------- > > Make check (Fedora 25). Manual testing with a handmade StatusUpdate message. > > > Thanks, > > James Peach > > --===============3315108834809989688==--