From reviews-return-53462-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 9 20:38:21 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72E09190E2 for ; Mon, 9 Jan 2017 20:38:21 +0000 (UTC) Received: (qmail 6712 invoked by uid 500); 9 Jan 2017 20:38:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 6681 invoked by uid 500); 9 Jan 2017 20:38:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 6651 invoked by uid 99); 9 Jan 2017 20:38:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 20:38:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 90B3A311B53; Mon, 9 Jan 2017 20:38:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2453307817573105769==" MIME-Version: 1.0 Subject: Re: Review Request 54613: Install a symlink rather than building mesos-slave twice. From: James Peach To: Jiang Yan Xu , Alex Clemmer , Joseph Wu , Michael Park , Benjamin Bannier , Vinod Kone Cc: Mesos ReviewBot , Kevin Klues , James Peach , mesos Date: Mon, 09 Jan 2017 20:38:19 -0000 Message-ID: <20170109203819.2955.38305@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54613/ X-Sender: James Peach References: <20170109202411.2955.92927@reviews.apache.org> In-Reply-To: <20170109202411.2955.92927@reviews.apache.org> Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============2453307817573105769== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote: > > What is the reason for this change? It seems much more intuitive for me to have a simple build directive that we simply remove once of the rename is complete, compared to a custom install-hook that creates a symlink. The rationale is that we don't need to spend time and space building annd installing an extra binary. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review160958 ----------------------------------------------------------- On Jan. 9, 2017, 8:02 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54613/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 8:02 p.m.) > > > Review request for mesos, Benjamin Bannier, Alex Clemmer, Joseph Wu, Michael Park, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6772 > https://issues.apache.org/jira/browse/MESOS-6772 > > > Repository: mesos > > > Description > ------- > > Install a symlink rather than building mesos-slave twice. > > > Diffs > ----- > > src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 > > Diff: https://reviews.apache.org/r/54613/diff/ > > > Testing > ------- > > Make install: > ``` > [jpeach@jpeach mesos.git]$ ls -l /opt/mesos/sbin/ > total 10448 > -rwxr-xr-x 1 root root 5116104 Dec 9 15:27 mesos-agent* > -rwxr-xr-x 1 root root 5539096 Dec 9 15:27 mesos-master* > lrwxrwxrwx 1 root root 11 Dec 9 15:27 mesos-slave -> mesos-agent* > ``` > > > Thanks, > > James Peach > > --===============2453307817573105769==--