From reviews-return-53461-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 9 20:35:19 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B192E190CB for ; Mon, 9 Jan 2017 20:35:19 +0000 (UTC) Received: (qmail 1927 invoked by uid 500); 9 Jan 2017 20:35:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 1902 invoked by uid 500); 9 Jan 2017 20:35:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 1881 invoked by uid 99); 9 Jan 2017 20:35:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 20:35:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 18258311B53; Mon, 9 Jan 2017 20:35:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0674316225133393545==" MIME-Version: 1.0 Subject: Re: Review Request 55355: Fixed an FD leak in the IO switchboard. From: Greg Mann To: Benjamin Bannier , Kevin Klues , Benjamin Mahler , Joseph Wu , Benjamin Hindman Cc: Greg Mann , mesos Date: Mon, 09 Jan 2017 20:35:18 -0000 Message-ID: <20170109203518.2898.72386@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55355/ X-Sender: Greg Mann References: <20170109203503.2955.63316@reviews.apache.org> In-Reply-To: <20170109203503.2955.63316@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============0674316225133393545== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/ ----------------------------------------------------------- (Updated Jan. 9, 2017, 8:35 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, Joseph Wu, and Kevin Klues. Repository: mesos Description ------- Previously, the IO switchboard could leak file descriptors because it held a reference to its server socket within the socket's accept loop. This patch explicitly discards the future containing this reference to eliminate the leak. Diffs ----- src/slave/containerizer/mesos/io/switchboard.cpp 67c51678e87389ab08a81fe4832cffd3d83bdae9 Diff: https://reviews.apache.org/r/55355/diff/ Testing ------- Run: `bin/mesos-tests.sh --gtest_repeat=-1 --gtest_filter="IOSwitchboardServerTest.AttachInput"` and then simultaneously execute `sudo lsof -p PID_of_test_process | wc -l` repeatedly to ensure that the number of open FDs is not increasing. Thanks, Greg Mann --===============0674316225133393545==--