From reviews-return-53399-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Jan 8 17:55:30 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5679519764 for ; Sun, 8 Jan 2017 17:55:30 +0000 (UTC) Received: (qmail 14930 invoked by uid 500); 8 Jan 2017 17:55:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 14895 invoked by uid 500); 8 Jan 2017 17:55:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 14881 invoked by uid 99); 8 Jan 2017 17:55:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Jan 2017 17:55:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B7731DF106; Sun, 8 Jan 2017 17:55:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7560308972732915550==" MIME-Version: 1.0 Subject: Re: Review Request 55139: Implemented parse methods for OCI image spec. From: Jie Yu To: Jie Yu , Gilbert Song Cc: Qian Zhang , mesos Date: Sun, 08 Jan 2017 17:55:28 -0000 Message-ID: <20170108175528.4232.39640@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55139/ X-Sender: Jie Yu References: <20170103141120.13569.46511@reviews.apache.org> In-Reply-To: <20170103141120.13569.46511@reviews.apache.org> X-ReviewBoard-Diff-For: include/mesos/oci/spec.hpp X-ReviewBoard-Diff-For: src/oci/spec.cpp Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============7560308972732915550== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55139/#review160843 ----------------------------------------------------------- include/mesos/oci/spec.hpp (lines 27 - 48) I would use template and template specification here: ``` template Try parse(const string& s); template <> Try parse(const string& s); ... ``` At callsite, you can do: ``` Try descriptor = parse(s); ``` - Jie Yu On Jan. 3, 2017, 2:11 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55139/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 2:11 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Implemented parse methods for OCI image spec. > > > Diffs > ----- > > include/mesos/oci/spec.hpp PRE-CREATION > src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 > src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 > src/oci/spec.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/55139/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > > --===============7560308972732915550==--