From reviews-return-53236-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 3 23:23:08 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35F7B1914E for ; Tue, 3 Jan 2017 23:23:08 +0000 (UTC) Received: (qmail 47188 invoked by uid 500); 3 Jan 2017 23:23:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47159 invoked by uid 500); 3 Jan 2017 23:23:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47134 invoked by uid 99); 3 Jan 2017 23:23:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 23:23:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 30A1D3105F1; Tue, 3 Jan 2017 23:23:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2595495262870824243==" MIME-Version: 1.0 Subject: Re: Review Request 55152: Fixed nested container docs and added a link to home.md. From: Avinash sridharan To: Neil Conway , Adam B , Jie Yu , Avinash sridharan , Vinod Kone , Anand Mazumdar Cc: Gilbert Song , mesos Date: Tue, 03 Jan 2017 23:23:07 -0000 Message-ID: <20170103232307.13478.76212@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Avinash sridharan X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55152/ X-Sender: Avinash sridharan References: <20170103214436.13569.96655@reviews.apache.org> In-Reply-To: <20170103214436.13569.96655@reviews.apache.org> Reply-To: Avinash sridharan X-ReviewRequest-Repository: mesos --===============2595495262870824243== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55152/#review160437 ----------------------------------------------------------- docs/nested-container-and-task-group.md (line 64) s/of Nested Container/of a Nested Container docs/nested-container-and-task-group.md (lines 67 - 69) We could re-write this as follows: In order for executors to launch nested containers, a new set of agent APIs have been introduced (described in the following sections), which would allow the exector to re-use the isolation semantics provided by the `MesosContainerizer` without needing to reimplement this code within the executor. While currently executors are assumed to be the primary consumers of the new agent APIs, its important to note that the API has been designed to allow any authorized operator to launch nested containers. docs/nested-container-and-task-group.md (line 209) s/2/two better to write the numeral in words when it modifies the noun. Lets not mention version numbers in the docs. We can re-write this as: Currently, this API supports only two levels of nesting. (You can start the above in a new paragraph for emphasis) docs/nested-container-and-task-group.md (line 211) Theoretically, we could have up to 32 nested levels, limited by the maximum dept of [pid namespace] - Avinash sridharan On Jan. 3, 2017, 9:44 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55152/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 9:44 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Avinash sridharan, Jie Yu, Neil Conway, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Fixed nested container docs and added a link to home.md. > > > Diffs > ----- > > docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4 > docs/nested-container-and-task-group.md debf9f82622557aff915dd04ef06a50793f496b6 > > Diff: https://reviews.apache.org/r/55152/diff/ > > > Testing > ------- > > https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md > > > Thanks, > > Gilbert Song > > --===============2595495262870824243==--