From reviews-return-53227-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 3 22:46:32 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD80219006 for ; Tue, 3 Jan 2017 22:46:31 +0000 (UTC) Received: (qmail 53299 invoked by uid 500); 3 Jan 2017 22:46:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 53266 invoked by uid 500); 3 Jan 2017 22:46:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 53244 invoked by uid 99); 3 Jan 2017 22:46:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 22:46:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E645A310D5C; Tue, 3 Jan 2017 22:46:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7903826105480001418==" MIME-Version: 1.0 Subject: Re: Review Request 54213: Supported more layers through symlink for aufs backend. From: Gilbert Song To: Zhitao Li , Jie Yu , Avinash sridharan , Qian Zhang , Artem Harutyunyan Cc: Gilbert Song , mesos Date: Tue, 03 Jan 2017 22:46:30 -0000 Message-ID: <20170103224630.13478.61706@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54213/ X-Sender: Gilbert Song References: <20161216180346.17251.45939@reviews.apache.org> In-Reply-To: <20161216180346.17251.45939@reviews.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============7903826105480001418== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54213/ ----------------------------------------------------------- (Updated Jan. 3, 2017, 2:46 p.m.) Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao Li. Changes ------- Rebased. Bugs: MESOS-6001 https://issues.apache.org/jira/browse/MESOS-6001 Repository: mesos Description ------- This issue is similar to MESOS-6000. We use the same solution (using symlinks) to resolve many-layer image issue with aufs backend. Diffs (updated) ----- src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b Diff: https://reviews.apache.org/r/54213/diff/ Testing ------- make check Tested by the new unit test `ROOT_AUFS_AufsBackendWithManyLayers` (see the following patch). Manually tested using a 37-layer image `gilbertsong/cirros:34`. It failed before the fix, and it passed after the fix. Thanks, Gilbert Song --===============7903826105480001418==--