From reviews-return-53215-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 3 21:16:16 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1BDE19B00 for ; Tue, 3 Jan 2017 21:16:16 +0000 (UTC) Received: (qmail 38824 invoked by uid 500); 3 Jan 2017 21:16:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 38798 invoked by uid 500); 3 Jan 2017 21:16:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 38779 invoked by uid 99); 3 Jan 2017 21:16:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 21:16:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A65D9310CAA; Tue, 3 Jan 2017 21:16:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5204706662904075292==" MIME-Version: 1.0 Subject: Re: Review Request 51052: Made mesos-docker-execute understand cgroups_enable_cfs. From: Zhitao Li To: Jie Yu , haosdent huang , Gilbert Song Cc: Zhitao Li , Mesos ReviewBot , mesos Date: Tue, 03 Jan 2017 21:16:15 -0000 Message-ID: <20170103211615.13478.70210@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zhitao Li X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51052/ X-Sender: Zhitao Li References: <20161012170203.1720.86044@reviews.apache.org> In-Reply-To: <20161012170203.1720.86044@reviews.apache.org> Reply-To: Zhitao Li X-ReviewRequest-Repository: mesos --===============5204706662904075292== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ ----------------------------------------------------------- (Updated Jan. 3, 2017, 9:16 p.m.) Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. Changes ------- Redo this patch on top of r/54821 Summary (updated) ----------------- Made mesos-docker-execute understand cgroups_enable_cfs. Bugs: MESOS-6134 https://issues.apache.org/jira/browse/MESOS-6134 Repository: mesos Description (updated) ------- This fixed cpu quota for command executor (which runs outside of the docker container) by ensuing --cpu-quota flag to docker run. Diffs (updated) ----- src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7 src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd Diff: https://reviews.apache.org/r/51052/diff/ Testing ------- I am now able to make docker containers launched through mesos-execute have a cpu quota. Also making sure `make check` still works on mac os for the linux only flag. Thanks, Zhitao Li --===============5204706662904075292==--