mesos-reviews mailing list archives: January 2017

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · 16 · 17 · Next »Thread · Author · Date
Ilya Pronin Re: Review Request 54873: Added asynchronous libcurl support to Mesos. Thu, 05 Jan, 18:36
Neil Conway Review Request 55218: Removed redundant `return` in libprocess. Thu, 05 Jan, 19:05
Neil Conway Review Request 55220: Cleaned up std::string usage in mesos. Thu, 05 Jan, 19:06
Neil Conway Review Request 55219: Cleaned up std::string usage in stout. Thu, 05 Jan, 19:06
Neil Conway Review Request 55221: Avoided needless copies in log tests. Thu, 05 Jan, 19:06
Neil Conway Review Request 55222: Avoided unnecessary copies in mesos. Thu, 05 Jan, 19:07
Neil Conway Review Request 55223: Removed unused namespace alias declarations in libprocess. Thu, 05 Jan, 19:07
Neil Conway Review Request 55224: Removed unused namespace alias declarations in mesos. Thu, 05 Jan, 19:07
Zhitao Li Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options. Thu, 05 Jan, 19:37
Zhitao Li Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options. Thu, 05 Jan, 19:38
Zhitao Li Re: Review Request 51052: Made mesos-docker-execute understand cgroups_enable_cfs. Thu, 05 Jan, 19:39
Zhitao Li Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set. Thu, 05 Jan, 19:39
Neil Conway Review Request 55226: Cleaned up std::string usage in libprocess. Thu, 05 Jan, 20:04
Neil Conway Re: Review Request 55220: Cleaned up std::string usage in mesos. Thu, 05 Jan, 20:04
Neil Conway Re: Review Request 55222: Avoided unnecessary copies in mesos. Thu, 05 Jan, 20:05
Neil Conway Re: Review Request 55224: Removed unused namespace alias declarations in mesos. Thu, 05 Jan, 20:07
Mesos ReviewBot Re: Review Request 55162: Stout: Added style fixes and some useful error messages. Thu, 05 Jan, 20:20
Avinash sridharan Re: Review Request 54688: Added a `docker_store_dir` flag to tests. Thu, 05 Jan, 22:15
Mesos ReviewBot Re: Review Request 55177: Fixed scheme handling in URL::parse(). Thu, 05 Jan, 22:18
Alex Clemmer Re: Review Request 55162: Stout: Added style fixes and some useful error messages. Thu, 05 Jan, 23:27
Alex Clemmer Re: Review Request 55004: CMake: renamed `stout_tests` to `stout-tests` to match autotools. Thu, 05 Jan, 23:58
Timothy Chen Re: Review Request 55177: Fixed scheme handling in URL::parse(). Thu, 05 Jan, 23:58
Alex Clemmer Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools. Thu, 05 Jan, 23:59
Alex Clemmer Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools. Fri, 06 Jan, 00:00
Alex Clemmer Re: Review Request 55006: CMake: renamed test binaries to match autotools. Fri, 06 Jan, 00:02
Alex Clemmer Re: Review Request 55162: Stout: Added style fixes and some useful error messages. Fri, 06 Jan, 00:03
Mesos ReviewBot Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64. Fri, 06 Jan, 00:07
James Peach Review Request 55238: Use os::spawn in the CNI isolator. Fri, 06 Jan, 01:12
James Peach Review Request 55239: Stop using os::system to extract fetcher archives. Fri, 06 Jan, 01:13
James Peach Review Request 55240: Stop using os::system to copy local files. Fri, 06 Jan, 01:15
James Peach Review Request 55241: Stop using os::system to validate perf event names. Fri, 06 Jan, 01:17
James Peach Review Request 55242: Stop using os::system to chown a directory hierarchy. Fri, 06 Jan, 01:18
Mesos ReviewBot Re: Review Request 55068: Added Capabilities to Framework struct of Hierarchical allocator. Fri, 06 Jan, 02:08
Mesos ReviewBot Re: Review Request 55224: Removed unused namespace alias declarations in mesos. Fri, 06 Jan, 05:12
Mesos ReviewBot Re: Review Request 54688: Added a `docker_store_dir` flag to tests. Fri, 06 Jan, 06:20
Jay Guo Review Request 55252: Added `_getRoles()` to extract some logic of `getRoles()`. Fri, 06 Jan, 06:43
Jay Guo Review Request 55253: Added 'roles' section in the response of `/state` endpoint. Fri, 06 Jan, 06:43
Jay Guo Review Request 55254: Inserted `getRoles` to `getState`. Fri, 06 Jan, 06:43
Jay Guo Review Request 55255: Added a test to check 'roles' is included in the `/state`. Fri, 06 Jan, 06:44
Jay Guo Review Request 55251: Added `filterRoles` method to extract some logic from `_roles`. Fri, 06 Jan, 06:44
Jay Guo Re: Review Request 55021: Added a framework capabilities struct. Fri, 06 Jan, 07:21
Jay Guo Re: Review Request 54650: Added validation for roles in ACCEPT call. Fri, 06 Jan, 07:53
Qian Zhang Re: Review Request 55191: Add hostname support to the network/cni isolator. Fri, 06 Jan, 08:14
Mesos ReviewBot Re: Review Request 55162: Stout: Added style fixes and some useful error messages. Fri, 06 Jan, 09:15
Mesos ReviewBot Re: Review Request 55242: Stop using os::system to chown a directory hierarchy. Fri, 06 Jan, 11:16
Ilya Pronin Re: Review Request 55177: Fixed scheme handling in URL::parse(). Fri, 06 Jan, 11:37
Ilya Pronin Re: Review Request 55177: Fixed scheme handling in URL::parse(). Fri, 06 Jan, 11:38
Mesos ReviewBot Re: Review Request 55255: Added a test to check 'roles' is included in the `/state`. Fri, 06 Jan, 13:13
Ilya Pronin Re: Review Request 54873: Added asynchronous libcurl support to Mesos. Fri, 06 Jan, 14:14
Mesos ReviewBot Re: Review Request 55191: Add hostname support to the network/cni isolator. Fri, 06 Jan, 14:57
Benjamin Bannier Review Request 55269: Avoided use of CHECK macros. Fri, 06 Jan, 15:16
Benjamin Bannier Review Request 55268: Avoided use of CHECK macros in libprocess. Fri, 06 Jan, 15:16
Mesos ReviewBot Re: Review Request 55269: Avoided use of CHECK macros. Fri, 06 Jan, 17:37
Jie Yu Re: Review Request 55191: Add hostname support to the network/cni isolator. Fri, 06 Jan, 18:58
Benjamin Bannier Review Request 55271: Disallow multi-role frameworks to change their roles. Fri, 06 Jan, 19:07
Avinash sridharan Re: Review Request 55191: Add hostname support to the network/cni isolator. Fri, 06 Jan, 19:16
Joseph Wu Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools. Fri, 06 Jan, 20:45
Joseph Wu Re: Review Request 55004: CMake: renamed `stout_tests` to `stout-tests` to match autotools. Fri, 06 Jan, 20:45
Joseph Wu Re: Review Request 55006: CMake: renamed test binaries to match autotools. Fri, 06 Jan, 20:46
Kapil Arya Re: Review Request 55268: Avoided use of CHECK macros in libprocess. Fri, 06 Jan, 23:26
Kapil Arya Re: Review Request 55269: Avoided use of CHECK macros. Fri, 06 Jan, 23:28
Mesos ReviewBot Re: Review Request 55271: Disallow multi-role frameworks to change their roles. Sat, 07 Jan, 01:26
Avinash sridharan Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store. Sat, 07 Jan, 07:18
Michael Park Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools. Sat, 07 Jan, 08:13
Michael Park Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools. Sat, 07 Jan, 08:21
Michael Park Re: Review Request 55006: CMake: renamed test binaries to match autotools. Sat, 07 Jan, 08:21
Michael Park Review Request 55296: Used `jsonify` in `operator<<` for `JSON::*` to reduce duplicate code. Sat, 07 Jan, 10:02
Michael Park Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C. Sat, 07 Jan, 10:05
Guangya Liu Re: Review Request 52728: Renamed `inspect` to `inspectContainer`. Sat, 07 Jan, 10:13
Guangya Liu Re: Review Request 52738: Ued `inspectImage` to get pulled image. Sat, 07 Jan, 10:14
Guangya Liu Re: Review Request 52738: Used `inspectImage` to get pulled image. Sat, 07 Jan, 10:15
Guangya Liu Re: Review Request 52680: Used full docker image name to force pull a iamge. Sat, 07 Jan, 11:29
Guangya Liu Re: Review Request 52727: Added `Labels` to docker image. Sat, 07 Jan, 11:33
Guangya Liu Re: Review Request 52666: Added support for `docker inspect image` in docker containerizer. Sat, 07 Jan, 11:47
Guangya Liu Re: Review Request 52738: Used `inspectImage` to get pulled image. Sat, 07 Jan, 11:51
Guangya Liu Re: Review Request 55271: Disallow multi-role frameworks to change their roles. Sat, 07 Jan, 12:19
Mesos ReviewBot Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C. Sat, 07 Jan, 13:04
Guangya Liu Re: Review Request 54898: Added a CHECK in updateFrameworkInfo. Sat, 07 Jan, 14:32
Mesos ReviewBot Re: Review Request 52738: Used `inspectImage` to get pulled image. Sat, 07 Jan, 15:11
Jie Yu Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64. Sat, 07 Jan, 18:42
Neil Conway Review Request 55300: Improved comments in agent. Sat, 07 Jan, 21:10
Neil Conway Review Request 55301: Cleaned up agent re-registration code in the master slightly. Sat, 07 Jan, 21:10
Neil Conway Review Request 55304: Cleaned up `using` statements. Sat, 07 Jan, 21:11
Neil Conway Review Request 55303: Cleaned up two test cases slightly. Sat, 07 Jan, 21:11
Neil Conway Review Request 55302: Improved OneWayPartitionTest.MasterToSlave. Sat, 07 Jan, 21:12
Neil Conway Review Request 55305: Fixed quoting in agent error message. Sat, 07 Jan, 21:12
Neil Conway Review Request 55306: Cleaned up slave recovery tests. Sat, 07 Jan, 21:12
Neil Conway Review Request 55307: Improved handling of agents that restart but never re-register. Sat, 07 Jan, 21:13
Mesos ReviewBot Re: Review Request 55307: Improved handling of agents that restart but never re-register. Sat, 07 Jan, 23:59
Benjamin Hindman Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket. Sun, 08 Jan, 03:22
Alex Clemmer Review Request 55311: Added `process::initialize` to default executor's `main`. Sun, 08 Jan, 06:28
Alex Clemmer Review Request 55312: Windows: Added parent hooks to subprocess. Sun, 08 Jan, 06:29
Alex Clemmer Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests. Sun, 08 Jan, 06:30
Benjamin Hindman Re: Review Request 54825: Made sure process::Loop instances can only be created as shared_ptrs. Sun, 08 Jan, 07:16
Benjamin Hindman Re: Review Request 54825: Made sure process::Loop instances can only be created as shared_ptrs. Sun, 08 Jan, 07:18
Alex Clemmer Review Request 55314: Windows: Added working Agent tests, moving pass rate ~75% -> ~87%. Sun, 08 Jan, 07:20
Benjamin Hindman Review Request 55315: Bug fixes from failing to hold onto PollSocketImpl reference. Sun, 08 Jan, 07:35
Benjamin Hindman Re: Review Request 55315: Bug fixes from failing to hold onto PollSocketImpl reference. Sun, 08 Jan, 07:42
Benjamin Hindman Review Request 55316: Used loop in Pipe::Reader::readAll. Sun, 08 Jan, 07:43
Benjamin Hindman Review Request 55317: Used loop in SocketImpl. Sun, 08 Jan, 07:44
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · 16 · 17 · Next »Thread · Author · Date
Box list
Dec 20203
Nov 202011
Oct 202050
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338