mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 56139: Removed redundant 'Times(1)' from agent validation tests.
Date Tue, 31 Jan 2017 22:42:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/#review163729
-----------------------------------------------------------



Bad patch!

Reviews applied: [56139, 56053, 56052, 56055, 55955, 55954]

Failed command: python support/apply-reviews.py -n -r 56053

Error:
2017-01-31 22:42:36 URL:https://reviews.apache.org/r/56053/diff/raw/ [4942/4942] -> "56053.patch"
[1]
error: patch failed: src/tests/slave_validation_tests.cpp:129
error: src/tests/slave_validation_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/16935/console

- Mesos Reviewbot


On Jan. 31, 2017, 10:36 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56139/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 10:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes calls to `.Times(1)` from `EXPECT_CALL`
> invocations in the agent validation tests because it is
> redundant.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8 
> 
> Diff: https://reviews.apache.org/r/56139/diff/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*Validation*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message