mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 55955: Added validation tests to ensure environment variable value is set.
Date Tue, 31 Jan 2017 22:36:43 GMT


> On Jan. 31, 2017, 7:58 p.m., Vinod Kone wrote:
> > src/tests/master_validation_tests.cpp, line 2678
> > <https://reviews.apache.org/r/55955/diff/2-3/?file=1616128#file1616128line2678>
> >
> >     We stopped using `Times(1)` because that is redundant. You can just do
> >     
> >     ```
> >     EXPECT_CALL(sched, registered(&driver, _, _));
> >     ```
> >     
> >     If there are more instances of that in this file, can you do a sweep in a different
review?

You can find the follow-up review here: https://reviews.apache.org/r/56139/


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55955/#review163705
-----------------------------------------------------------


On Jan. 31, 2017, 10:23 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55955/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 10:23 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-6991
>     https://issues.apache.org/jira/browse/MESOS-6991
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `value` field within `Environment::Variable` is being
> changed to `optional`, but for the time being we will
> enforce that it must be set for backward compatibility.
> This patch adds tests to ensure that environment variables
> with unset values are correctly rejected.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp c88cd34fd214f111cff62591aa5fc03eb62567e4 
>   src/tests/health_check_tests.cpp 710cb66eff6c4447caa22772f0cdc97cfa582c50 
>   src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8 
>   src/tests/slave_validation_tests.cpp 5de771114982751e7796f55dcacd4384c6989efb 
> 
> Diff: https://reviews.apache.org/r/55955/diff/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --gtest_filter="*Validation*"
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message