mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56052: Added the 'Secret' protobuf message.
Date Tue, 31 Jan 2017 20:20:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56052/#review163710
-----------------------------------------------------------




include/mesos/mesos.proto (line 1952)
<https://reviews.apache.org/r/56052/#comment235189>

    s/priviledged/privileged/



include/mesos/mesos.proto (line 1954)
<https://reviews.apache.org/r/56052/#comment235190>

    s/modified/used/



include/mesos/mesos.proto (line 1979)
<https://reviews.apache.org/r/56052/#comment235191>

    Add a comment saying only one of `Reference` and `Value` must be set.



include/mesos/v1/mesos.proto (line 1951)
<https://reviews.apache.org/r/56052/#comment235192>

    ditto.


- Vinod Kone


On Jan. 29, 2017, 5:07 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56052/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2017, 5:07 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-6996
>     https://issues.apache.org/jira/browse/MESOS-6996
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new `Secret` protobuf message which
> is designed to serve as a generic mechanism for passing
> priviledged information within Mesos.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a08b8fb2edf26ae730467557ae0e33e3d4252593 
>   include/mesos/v1/mesos.proto 4a4609e7db659252ef7f1ca61f8ba079b901b7d0 
> 
> Diff: https://reviews.apache.org/r/56052/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message