mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50974: Documented all the API calls for Operator HTTP API.
Date Tue, 31 Jan 2017 19:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50974/#review163702
-----------------------------------------------------------


Fix it, then Ship it!





docs/operator-http-api.md (line 36)
<https://reviews.apache.org/r/50974/#comment235174>

    URI with trailing slash doesn't work with Mesos. This should be "/api/v1"
    
    Please fix here and everywhere else.



docs/operator-http-api.md (line 40)
<https://reviews.apache.org/r/50974/#comment235175>

    s/Accept-Type/Accept/
    
    Please fix here and everywhere else.



docs/operator-http-api.md (line 1222)
<https://reviews.apache.org/r/50974/#comment235177>

    s/all the agent informations of a master/information about all the agents known to the
master/



docs/operator-http-api.md (line 1349)
<https://reviews.apache.org/r/50974/#comment235178>

    s/registered to the master/known to the master/



docs/operator-http-api.md (line 1405)
<https://reviews.apache.org/r/50974/#comment235179>

    s/registered to the master/known to the master/



docs/operator-http-api.md (line 1456)
<https://reviews.apache.org/r/50974/#comment235180>

    s/known tasks/tasks known to the master/



docs/operator-http-api.md (line 3003)
<https://reviews.apache.org/r/50974/#comment235181>

    do you want to add the "at the current time" suffix to these calls on master as well?


- Vinod Kone


On Nov. 28, 2016, 6:50 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50974/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5992
>     https://issues.apache.org/jira/browse/MESOS-5992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented all the API calls for Operator HTTP API.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
> 
> Diff: https://reviews.apache.org/r/50974/diff/
> 
> 
> Testing
> -------
> 
> Checked the generated page through "rake dev".
> Validated and formatted all the JSON snippets with:
> http://jsonlint.com/
> http://jsonviewer.stack.hu/
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message