mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 54650: Added validation for roles in ACCEPT call.
Date Tue, 31 Jan 2017 16:08:55 GMT


> On Dec. 13, 2016, 4:04 p.m., Guangya Liu wrote:
> > src/master/validation.cpp, line 1411
> > <https://reviews.apache.org/r/54650/diff/3/?file=1582390#file1582390line1411>
> >
> >     Shall we add some check here to make sure the `allocation_info` exist as this
field is `optional`?
> 
> Benjamin Mahler wrote:
>     That sounds good to me, note that it means we can't land this patch until we land
my allocator / master changes.
> 
> Jay Guo wrote:
>     will change accordingly when that's done.

Note that the current implementation will also work if one mixed allocated and not allocated
resources (`_role` would just be an empty string for unallocated resources). I think we should
continue handling that edge case.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54650/#review159009
-----------------------------------------------------------


On Dec. 13, 2016, 5:41 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54650/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 5:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6637
>     https://issues.apache.org/jira/browse/MESOS-6637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For a multi-role framework, it may receive offers for different roles
> in that framework. However, we disallow multiple offers with different
> roles being accepted in single ACCEPT call.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
> 
> Diff: https://reviews.apache.org/r/54650/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message