mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`.
Date Mon, 30 Jan 2017 19:28:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55543/#review163558
-----------------------------------------------------------



Discussed this offline.  In summary, we want to prevent users from (shooting themselves in
the foot) bypassing the CMake check by doing something like:
```
PreferredToolArchitecture=x64 cmake ..
msbuild Mesos.sln /m
```

The current solution is effectively only checked at "configure" time.  We should add a build-time
step to error out instead.

- Joseph Wu


On Jan. 28, 2017, 11:21 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55543/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2017, 11:21 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6720
>     https://issues.apache.org/jira/browse/MESOS-6720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before building Mesos on a Windows machine, it is necessary to set
> `%PreferredToolArchitecture%` to the value `x64`. This is necessary to
> work around (at least) two bugs in the MSVC backend: in particular, the
> linker can sometimes take hours or days to link `mesos-x.x.x.lib`, and
> the build system occasionally finds it self spuriously unable to find
> file `mesos-x.x.x.lib` to link against.
> 
> These issues are well-known and documented (e.g., in the official Mesos
> "getting started" document), but it is better to simply refuse to build
> Mesos at all on Windows unless that environment variable is set.
> 
> This commit will introduce such a check.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 560935b81603dc58c167918d36e2ae0a4060673d 
> 
> Diff: https://reviews.apache.org/r/55543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message