mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <>
Subject Re: Review Request 56080: Fixed error handling when writing to a cgroup control file.
Date Mon, 30 Jan 2017 19:07:54 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 30, 2017, 7:07 p.m.)

Review request for mesos and Jie Yu.


Updated test according to review comments.

Bugs: MESOS-7020

Repository: mesos


Due to internal buffering in ofstream, actual write to the underlying
device may not be performed by the time of checking for failures.
This patch flushes written data to ensure fail check uses actual value.

Diffs (updated)

  src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 
  src/tests/containerizer/cgroups_tests.cpp 5c1ef70fb1feb76de602418286989b48563f26ff 



sudo make check


Dmitry Zhuk

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message