-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56080/#review163531
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/cgroups_tests.cpp (lines 497 - 498)
<https://reviews.apache.org/r/56080/#comment234987>
Let's move this up right below:
```
ASSERT_SOME(cgroups::create(hierarchy, TEST_CGROUPS_ROOT));
```
- Jie Yu
On Jan. 30, 2017, 3:20 p.m., Dmitry Zhuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56080/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 3:20 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7020
> https://issues.apache.org/jira/browse/MESOS-7020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to internal buffering in ofstream, actual write to the underlying
> device may not be performed by the time of checking for failures.
> This patch flushes written data to ensure fail check uses actual value.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8
> src/tests/containerizer/cgroups_tests.cpp 5c1ef70fb1feb76de602418286989b48563f26ff
>
> Diff: https://reviews.apache.org/r/56080/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Dmitry Zhuk
>
>
|