mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55625: Prevented certain kinds of gaming the quota system.
Date Mon, 30 Jan 2017 16:55:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55625/
-----------------------------------------------------------

(Updated Jan. 30, 2017, 5:55 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
-------

Removed the notion of "common" resource kinds.


Bugs: MESOS-6432
    https://issues.apache.org/jira/browse/MESOS-6432


Repository: mesos


Description
-------

In the certain coarse-grained allocation scheme it is possible to game
quota since the allocator will perform allocations until the quotas
for all resource kinds are satisfied. This can lead to allocations for
certain resource kinds far exceeding the set quota.

This patch changes the notion of what constitutes a "satisfied quota".
Where before a quota could only be satisfied if for all resource kinds
allocations had been me up to the set quota, we now consider a quota
satisfied as soon as at least one resource kinds is allocated up to
the set quota. We here take only "common" resource kinds into account
where a common resource is a resource present on every agent node. The
notion of common resource kinds is needed to avoid strong bias from
rare resources in the introduced quota allocation scheme.

Ultimately this change can only be temporary and should be replaced
with a more complete fix, e.g., chunked allocations, see MESOS-3765.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp f471b6848bebae601a7a0509e9c6ad5eab4fa4a2 
  src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c 

Diff: https://reviews.apache.org/r/55625/diff/


Testing
-------

Tested of various Linux configurations in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message