mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 55825: Augmented printing of Resources to include AllocationInfo.
Date Mon, 30 Jan 2017 01:21:00 GMT


> On Jan. 25, 2017, 11:10 a.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 822
> > <https://reviews.apache.org/r/55825/diff/1/?file=1611732#file1611732line822>
> >
> >     How about not clear this but keep the `allocated` label for all of the test
or just add this to the end of this test after line 883? This can convine us that the `allocated`
label works for all kind of resources.

Well, why do we need to be convinced of that? I think we can leverage a bit of internal knowledge
here to simplify the test: that the printing of allocation info is orthogonal to other properties
of the resource.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55825/#review162939
-----------------------------------------------------------


On Jan. 23, 2017, 2:04 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55825/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 2:04 a.m.)
> 
> 
> Review request for mesos, Jay Guo, Guangya Liu, and Michael Park.
> 
> 
> Bugs: MESOS-6970
>     https://issues.apache.org/jira/browse/MESOS-6970
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignoring whether there is a disk info, the format is as follows:
> name(reservedrole[, principal[, labels]])(allocatedrole):value
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45 
>   src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 
>   src/v1/resources.cpp da4701c03020ff9c33ef995cd0af437d8827c267 
> 
> Diff: https://reviews.apache.org/r/55825/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message