mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 55825: Augmented printing of Resources to include AllocationInfo.
Date Mon, 30 Jan 2017 01:20:59 GMT


> On Jan. 25, 2017, 10:19 a.m., Michael Park wrote:
> > src/common/resources.cpp, line 1942
> > <https://reviews.apache.org/r/55825/diff/1/?file=1611731#file1611731line1942>
> >
> >     Labeling `allocated:` seems okay to me, but also seems to be new to this format.
> >     
> >     It's not clear to me what direction we're going with this, seeing as it's gotten
(and getting) more complicated.
> >     
> >     I think the eventual plan is to move to using JSON for this representation?
> >     
> >     Just would like your quick thoughts on this.

I originally went without the label, and found it quite confusing (note that the reservation
info currently shows principal without a label and that's also fairly confusing). The difficulty
in moving to JSON for logging is that the JSON is fairly verbose compared to the current short
string format.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55825/#review162933
-----------------------------------------------------------


On Jan. 23, 2017, 2:04 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55825/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 2:04 a.m.)
> 
> 
> Review request for mesos, Jay Guo, Guangya Liu, and Michael Park.
> 
> 
> Bugs: MESOS-6970
>     https://issues.apache.org/jira/browse/MESOS-6970
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignoring whether there is a disk info, the format is as follows:
> name(reservedrole[, principal[, labels]])(allocatedrole):value
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45 
>   src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 
>   src/v1/resources.cpp da4701c03020ff9c33ef995cd0af437d8827c267 
> 
> Diff: https://reviews.apache.org/r/55825/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message