mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 51053: Update leveldb to 1.19.
Date Sun, 29 Jan 2017 14:52:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/
-----------------------------------------------------------

(Updated Jan. 29, 2017, 2:52 p.m.)


Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod
Kone.


Changes
-------

Rebase


Bugs: MESOS-970
    https://issues.apache.org/jira/browse/MESOS-970


Repository: mesos


Description (updated)
-------

Leveldb in modern version is required to support s390x and arm64.
It's also required to replace default byte-wise comparator
with varint comparator in \`src/log/leveldb.cpp\`.


Diffs (updated)
-----

  3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8 
  3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef 
  3rdparty/leveldb-1.19.patch PRE-CREATION 
  3rdparty/leveldb-1.19.tar.gz PRE-CREATION 
  3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
  3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
  3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b 
  LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a 
  src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
  src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5 

Diff: https://reviews.apache.org/r/51053/diff/


Testing
-------

make -j 8 distcheck
benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872


Thanks,

Tomasz Janiszewski


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message