mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 55030: CMake: Added source groups for libprocess build.
Date Sun, 29 Jan 2017 07:19:35 GMT


> On Jan. 25, 2017, 12:29 a.m., Joseph Wu wrote:
> > This review is partially un-done by https://reviews.apache.org/r/55604/ .  Can you
separate the source-grouping changes into https://reviews.apache.org/r/55604/ ?  And leave
the CMake lists rearrangement in this review?

We still need this change because we need to add the `.hpp` files to the call to `add_executable`
in order for them to show up as source groups. I've rebased to account for your recent changes.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/#review162883
-----------------------------------------------------------


On Jan. 29, 2017, 7:18 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55030/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2017, 7:18 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3542
>     https://issues.apache.org/jira/browse/MESOS-3542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently in IDEs such as XCode and Visual Studio, all mesos source
> files are grouped into one huge folder, with no attempt made to reflect
> the hierarchy of folders that exist on disk.
> 
> This commit groups libprocess files into relevant source groups so that
> they appear in a sensible directory structure in these IDEs.
> 
> In addition to beginning to directly address MESOS-3542, this is also
> (indirectly) the first step towards addressing the problem of breaking
> libmesos up into smaller binaries (MESOS-3542).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt ab362aa476e528deef691239a70f0be9d864e6c0 
>   3rdparty/libprocess/src/tests/CMakeLists.txt b298bbe042cabcb18169da1923562e9956374232

> 
> Diff: https://reviews.apache.org/r/55030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message