mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.
Date Sat, 28 Jan 2017 23:34:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 28, 2017, 11:34 p.m.)

Review request for mesos, Jan Schlicht and Vinod Kone.


Addressed comments, added more validation.

Bugs: MESOS-6991

Repository: mesos


To prepare for future work which will enable the
modular fetching of secrets, we should change the
Environment.Variable.Value field from required to
optional. This way, the field can be left empty
and filled in by a secret fetching module.

Diffs (updated)

  include/mesos/mesos.proto a08b8fb2edf26ae730467557ae0e33e3d4252593 
  include/mesos/v1/mesos.proto 4a4609e7db659252ef7f1ca61f8ba079b901b7d0 
  src/checks/checker.cpp 8d7285af40d9633608178ec239d3b8d65d3a2725 
  src/checks/health_checker.cpp e70bd7936752613a4f92c70c4c61cd7cdf7c4ee5 
  src/common/validation.hpp fee955139d9699caa651d9bbd03342f2eba8143f 
  src/common/validation.cpp b2548ad87b4227d6e498c49b5694acb362f6281b 
  src/master/validation.cpp e3f71be16ff21a1b4e10ad59846d9b06691bc1b9 
  src/slave/validation.cpp c30a0ebf044ac81b087a8a599c7476bdc16bef18 



Testing information at the end of this review chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message