mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55694: CMake: Separated Stout system headers from Stout API headers.
Date Sat, 28 Jan 2017 01:12:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55694/#review163368
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On Jan. 18, 2017, 5:23 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55694/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 5:23 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-3932
>     https://issues.apache.org/jira/browse/MESOS-3932
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3932 specifies a bug that causes spurious warnings to be printed
> when building Mesos.
> 
> Many of these warnings can be eliminated simply by correctly marking off
> the third-party dependencies as `SYSTEM` headers when we specify the
> include path.
> 
> This commit will thus separate out the headers of Stout's third-party
> dependencies from the core Stout API headers, and include them as
> `SYSTEM` headers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348

>   3rdparty/stout/cmake/StoutTestsConfigure.cmake d3bd72e8eba77213095da6cabb3a6d6f4d30941c

>   3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae 
> 
> Diff: https://reviews.apache.org/r/55694/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message