mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.
Date Sat, 28 Jan 2017 00:33:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55607/#review163364
-----------------------------------------------------------


Ship it!




Quickly verified:
```
cmake ..
ls bin  # Looks correct

cat bin/mesos-agent.sh  # Looks correct
```


cmake/MesosConfigure.cmake (lines 222 - 224)
<https://reviews.apache.org/r/55607/#comment234772>

    We generally put `NOTE`s on a newline.  And sometimes we put an extra newline before one
(especially after big comment blocks).


- Joseph Wu


On Jan. 26, 2017, 1:20 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55607/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 1:20 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6757
>     https://issues.apache.org/jira/browse/MESOS-6757
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This resolves MESOS-6757.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake ce127e1e8c5c33ad8badef6fb3ac9f50ade9056f 
> 
> Diff: https://reviews.apache.org/r/55607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message