mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 56001: Fixed a few executor segfaults during cleanup.
Date Thu, 26 Jan 2017 22:28:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56001/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu.


Bugs: MESOS-6989
    https://issues.apache.org/jira/browse/MESOS-6989


Repository: mesos


Description
-------

The addition of `process::finalize` at the end of some binaries
led to some segfaulting at the end of the binaries' lifetimes.
This is mostly due calling destructors of libprocess actor
wrappers, which require an initialized libprocess to function.

This commit explicitly calls the destructors on the default
and docker executor actors prior to calling `process::finalize`.


Diffs
-----

  src/docker/executor.cpp f353341c9509532653e2ef8802f20259ce67930c 
  src/launcher/default_executor.cpp a03794934adb93868734f8cf00b337a1bff9b5ab 

Diff: https://reviews.apache.org/r/56001/diff/


Testing
-------

sudo src/mesos-tests --gtest_filter="*ROOT*DOCKER*" --verbose

Checked that all executors exited with status code 0, rather than 11.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message