mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55599: CMake: Added `GroupSource` function to automate IDE source grouping.
Date Thu, 26 Jan 2017 22:10:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55599/#review163184
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Jan. 26, 2017, 1:12 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55599/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 1:12 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake allows users to declare groups of source files, which it uses to
> (among other things) present source in a directory-like tree of files in
> IDEs like XCode and Visual Studio.
> 
> Currently this is a manual process: we group the source in each folder
> manually and declare it as a source group to CMake.
> 
> This commit will introduce a CMake macro that automates this process
> away, providing control over many aspects, such as where the group tree
> should be rooted, what the root should be named, and so on.
> 
> This macro indirectly partially addresses MESOS-3542, which will help us
> to separate out Mesos builds into many libraries, rather than one
> single, monolithic libmesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/GroupSource.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55599/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message