mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 55549: Windows: Added health checker to build.
Date Thu, 26 Jan 2017 08:34:48 GMT


> On Jan. 24, 2017, 9:37 p.m., Joseph Wu wrote:
> > src/health-check/tcp_connect.cpp, lines 33-38
> > <https://reviews.apache.org/r/55549/diff/1/?file=1605582#file1605582line33>
> >
> >     Libprocess headers should go above stout headers.

Oh, did this change recently, or have I just always done this wrong?


> On Jan. 24, 2017, 9:37 p.m., Joseph Wu wrote:
> > src/health-check/tcp_connect.cpp, lines 148-150
> > <https://reviews.apache.org/r/55549/diff/1/?file=1605582#file1605582line148>
> >
> >     Should there be a `process::finalize` here?

Actually, now that I think about it, this should not take a dependency on libprocess at all.
Let's use the Stout WSA functions instead.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55549/#review162853
-----------------------------------------------------------


On Jan. 15, 2017, 9:35 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55549/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 9:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
>     https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a blocker for MESOS-6709, which requires both the health checker
> and the TCP connector to build and work on Windows.
> 
> 
> Diffs
> -----
> 
>   src/health-check/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7 
>   src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26 
>   src/health-check/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9 
> 
> Diff: https://reviews.apache.org/r/55549/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message